TerribleCodeClub
/
romulus
12
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix authenticated data endian issue

This commit is contained in:
Simon 2022-02-02 02:01:56 +00:00
parent 9cd10865da
commit 9f0a623f7c
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Romulus-M/encrypt_wrapper.c
View File

@ -43,6 +43,7 @@ int encrypt(packet *packet, unsigned char *outBuf, UINT16 *len, unsigned char *k
unsigned char *m = packet->Data; unsigned char *m = packet->Data;
// additional text // additional text
packet->DataType = __bswap_16(packet->DataType);
int adlen = sizeof(packet->DataType); int adlen = sizeof(packet->DataType);
unsigned char *ad = (unsigned char *)&packet->DataType; unsigned char *ad = (unsigned char *)&packet->DataType;
@ -61,8 +62,6 @@ int encrypt(packet *packet, unsigned char *outBuf, UINT16 *len, unsigned char *k
} }
// type 0 1 // type 0 1
// Swap after adding it as additional data
packet->DataType = __bswap_16(packet->DataType);
int loc = 0; int loc = 0;
memcpy(&outBuf[loc], &packet->DataType, sizeof(UINT16)); memcpy(&outBuf[loc], &packet->DataType, sizeof(UINT16));
loc += sizeof(UINT16); loc += sizeof(UINT16);
@ -97,6 +96,7 @@ int decrypt(packetEx *packet, unsigned char *inBuf, UINT16 len, unsigned char *k
{ {
return 1; return 1;
} }
DEBUG_PRINT("line %d\n", __LINE__); DEBUG_PRINT("line %d\n", __LINE__);
memcpy(&packet->DataType, &inBuf[loc], sizeof(UINT16)); memcpy(&packet->DataType, &inBuf[loc], sizeof(UINT16));
loc += sizeof(UINT16); loc += sizeof(UINT16);
@ -105,7 +105,6 @@ int decrypt(packetEx *packet, unsigned char *inBuf, UINT16 len, unsigned char *k
memcpy(&packet->Size, &inBuf[loc], sizeof(UINT16)); memcpy(&packet->Size, &inBuf[loc], sizeof(UINT16));
loc += sizeof(UINT16); loc += sizeof(UINT16);
packet->DataType = __bswap_16(packet->DataType);
packet->Size = __bswap_16(packet->Size); packet->Size = __bswap_16(packet->Size);
packet->Id = __bswap_32(packet->Id); packet->Id = __bswap_32(packet->Id);
@ -138,6 +137,9 @@ int decrypt(packetEx *packet, unsigned char *inBuf, UINT16 len, unsigned char *k
DEBUG_PRINT("line %d mlen:%d clen:%d\n", __LINE__, mlen, clen); DEBUG_PRINT("line %d mlen:%d clen:%d\n", __LINE__, mlen, clen);
int ret = romulus_m_decrypt(m, &mlen, 0, c, clen, ad, adlen, npub, key); int ret = romulus_m_decrypt(m, &mlen, 0, c, clen, ad, adlen, npub, key);
DEBUG_PRINT("line %d packet:%d, mlen %d\n", __LINE__, packet->Size, mlen); DEBUG_PRINT("line %d packet:%d, mlen %d\n", __LINE__, packet->Size, mlen);
// swap after decrypt, we sign the big endian bytes
packet->DataType = __bswap_16(packet->DataType);
if (ret == 0) if (ret == 0)
{ {
DEBUG_PRINT("line %d\n", __LINE__); DEBUG_PRINT("line %d\n", __LINE__);