jackhadrill
/
ut_metadata
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

reduce max bitfield size by 100x

This commit is contained in:
Feross Aboukhadijeh 2014-04-19 18:26:19 -07:00
parent 2d0be5bb80
commit 05abd138cd
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
index.js
View File

@ -4,7 +4,7 @@ var EventEmitter = require('events').EventEmitter
var inherits = require('inherits') var inherits = require('inherits')
var Rusha = require('rusha-browserify') // Fast SHA1 (works in browser) var Rusha = require('rusha-browserify') // Fast SHA1 (works in browser)
var BITFIELD_GROW = 100000 var BITFIELD_GROW = 1000
var PIECE_LENGTH = 16 * 1024 var PIECE_LENGTH = 16 * 1024
function sha1 (buf) { function sha1 (buf) {
@ -25,9 +25,9 @@ module.exports = function (metadata) {
this._remainingRejects = null // how many reject messages to tolerate before quitting this._remainingRejects = null // how many reject messages to tolerate before quitting
this._fetching = false this._fetching = false
// The largest torrent that I know of (the Geocities archive) is ~641 GB and has // The largest .torrent file that I know of is ~1-2MB, which is ~100 pieces.
// ~41,000 pieces. Therefore, cap the bitfield to 100,000 bits so a malicious peer // Therefore, cap the bitfield to 1,000 bits so a malicious peer can't make it grow
// can't make it grow to fill all memory. // to fill all memory.
this._bitfield = new BitField(0, { grow: BITFIELD_GROW }) this._bitfield = new BitField(0, { grow: BITFIELD_GROW })
if (Buffer.isBuffer(metadata)) { if (Buffer.isBuffer(metadata)) {