From 935f1e25ca87c02c6e1ce8201ea3ae0255572ec5 Mon Sep 17 00:00:00 2001
From: Sarah <sarah.bloor-2@student.manchester.ac.uk>
Date: Fri, 15 Apr 2022 17:09:56 +0100
Subject: [PATCH] change hidden theme calculation

---
 get_hidden_themes.py | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/get_hidden_themes.py b/get_hidden_themes.py
index 6990393..75d173a 100644
--- a/get_hidden_themes.py
+++ b/get_hidden_themes.py
@@ -5,8 +5,7 @@ from progress.bar import IncrementalBar
 
 
 def get_hidden_themes(imdb_ids):
-    hidden_themes = set()
-    is_first = True
+    film_keywords = []
 
     with IncrementalBar('Retrieving movie data', max=len(imdb_ids), suffix='%(percent).1f%% - %(eta)ds remaining', check_tty=False) as bar:
         for imdb_id in imdb_ids:
@@ -14,14 +13,12 @@ def get_hidden_themes(imdb_ids):
 
             if 'keywords' in movie_data:
                 keywords = set(movie_data['keywords'])
-                if is_first:
-                    hidden_themes = keywords
-                    is_first = False
-                else:
-                    hidden_themes = hidden_themes.intersection(keywords)
+                film_keywords.append(keywords)
 
         bar.next()
 
+    hidden_themes = set.intersection(*film_keywords)
+
     return hidden_themes