fix for no page url

markdown_utils/MarkdownUtils.py

@@ -0,0 +1,35 @@
+
+def generate_markdown_link(text, url):
+    return "[{}]({})".format(text, url)
+
+
+class MarkdownTable:
+
+    headers = []
+    rows = []
+
+    def __init__(self, headers):
+        self.headers = headers
+
+    def add_row(self, row_data):
+        if len(row_data) != len(self.headers):
+            raise Exception("Wrong number of row entries.")
+        else:
+            self.rows.append(row_data)
+
+    def __str__(self):
+        table = "|"
+
+        for header in self.headers:
+            table += " {} |".format(header)
+
+        table += "\n"
+
+        table += "|"
+        table += " - |" * len(self.headers)
+
+        for row in self.rows:
+            table += "\n"
+            table += " | ".join(map(str, row))
+
+        return table

vcinema_utils/VCinemaUtils.py

@@ -2,8 +2,9 @@ from collections import Counter
 from concurrent.futures import ThreadPoolExecutor
 import csv
 
-from imdb_utils import IMDbUtils
 from bookstack import Bookstack
+from imdb_utils import IMDbUtils
+from markdown_utils import MarkdownUtils
 
 
 JACKNET_WIKI_URL = "https://wiki.jacknet.io"
@@ -130,16 +131,12 @@ def get_film_list(films):
         return ""
 
 
-def generate_markdown_link(text, url):
-    return "[{}]({})".format(text, url)
-
-
 def generate_imdb_film_link(film):
-    return generate_markdown_link(film['title'], generate_imdb_url(film['imdb_id']))
+    return MarkdownUtils.generate_markdown_link(film['title'], generate_imdb_url(film['imdb_id']))
 
 
 def generate_wikipedia_page_link(page_title):
-    return generate_markdown_link(page_title, generate_wikipedia_url(page_title))
+    return MarkdownUtils.generate_markdown_link(page_title, generate_wikipedia_url(page_title))
 
 
 def generate_imdb_url(imdb_id):

wiki_pages/FilmsByCountry.py

@@ -7,6 +7,7 @@ import worldmap
 import warnings
 
 from bookstack import Bookstack
+from markdown_utils import MarkdownUtils
 from vcinema_utils import VCinemaUtils
 
 warnings.filterwarnings("ignore")
@@ -37,7 +38,7 @@ def build_page(films_by_country):
     png_data = draw_map(country_counter)
     encoded = base64.b64encode(png_data).decode("utf-8")
     image = "![](data:image/png;base64,{})".format(encoded)
-    page = image + "\n" + table
+    page = image + "\n" + str(table)
 
     return page
 
@@ -60,22 +61,17 @@ def build_table(films_by_country):
 
     flags = get_flags_dict()
 
-    table = "| Country | Films |\n| - | - |"
+    table = MarkdownUtils.MarkdownTable(["Country", "Films"])
 
     for country, films in films_by_country_sorted.items():
-        table += "\n"
-
-        row_data = []
-
-        country_label = country
         if country in flags.keys():
-            country_label += " "
+            country += " " + flags[country]
-            country_label += flags[country]
 
-        row_data.append(country_label)
+        films = VCinemaUtils.get_film_list(films)
-        row_data.append(VCinemaUtils.get_film_list(films))
 
-        table += " | ".join(row_data)
+        row_data = [country, films]
+
+        table.add_row(row_data)
 
     return table
 

wiki_pages/FilmsByReference.py

@@ -2,6 +2,7 @@ from collections import OrderedDict
 import wikipedia
 
 from bookstack import Bookstack
+from markdown_utils import MarkdownUtils
 from vcinema_utils import VCinemaUtils
 
 # Page ID of https://wiki.jacknet.io/books/vcinema/page/references
@@ -79,22 +80,15 @@ def update_page(token_id, token_secret, films_by_reference_keyword):
 def build_page(films_by_reference):
     films_by_reference = OrderedDict(sorted(films_by_reference.items(), key=lambda t: t[0]))
 
-    table = "| Referenced | Films |\n| - | - |"
+    table = MarkdownUtils.MarkdownTable(["Referenced", "Films"])
 
     for reference, referenced in films_by_reference.items():
-        table += "\n"
+        if referenced["url"] is not None:
+            reference = MarkdownUtils.generate_markdown_link(reference, referenced["url"])
+        films = VCinemaUtils.get_film_list(referenced["films"])
 
-        row_data = []
+        row_data = [reference, films]
 
-        reference_url = referenced["url"]
+        table.add_row(row_data)
-        referenced_films = referenced["films"]
 
-        if reference_url is None:
+    return str(table)
-            row_data.append(reference)
-        else:
-            row_data.append(VCinemaUtils.generate_markdown_link(reference, reference_url))
-        row_data.append(VCinemaUtils.get_film_list(referenced_films))
-
-        table += " | ".join(row_data)
-
-    return table

wiki_pages/FilmsByYear.py

@@ -1,6 +1,7 @@
 from collections import OrderedDict
 
 from bookstack import Bookstack
+from markdown_utils import MarkdownUtils
 from vcinema_utils import VCinemaUtils
 
 # Page ID of https://wiki.jacknet.io/books/vcinema/page/films-by-release-year
@@ -19,17 +20,14 @@ def update_page(token_id, token_secret, films_by_year):
 
 
 def build_page(films_by_year):
-    films_by_year_sorted = OrderedDict(sorted(films_by_year.items(), key=lambda t: t[0], reverse=True))
+    films_by_year = OrderedDict(sorted(films_by_year.items(), key=lambda t: t[0], reverse=True))
 
-    page = "| Year | Films |\n| - | - |"
+    table = MarkdownUtils.MarkdownTable(["Year", "Films"])
 
-    for year in films_by_year_sorted.keys():
+    for year in films_by_year.keys():
-        page += "\n"
+        films = VCinemaUtils.get_film_list(films_by_year[year])
 
-        row_data = []
+        row_data = [year, films]
-        row_data.append(str(year))
+        table.add_row(row_data)
-        row_data.append(VCinemaUtils.get_film_list(films_by_year_sorted[year]))
 
-        page += " | ".join(row_data)
+    return str(table)
-
-    return page

wiki_pages/HiddenThemes.py

@@ -1,6 +1,7 @@
 from collections import OrderedDict
 
 from bookstack import Bookstack
+from markdown_utils import MarkdownUtils
 from vcinema_utils import VCinemaUtils
 
 # Page ID of https://wiki.jacknet.io/books/vcinema/page/films-by-reference
@@ -60,14 +61,11 @@ def update_page(token_id, token_secret, hidden_themes):
 def build_page(hidden_themes):
     hidden_themes = OrderedDict(sorted(hidden_themes.items(), key=lambda t: t[0]))
 
-    table = "| Date | Films | Hidden Themes |\n| - | - | - |"
+    table = MarkdownUtils.MarkdownTable(["Date", "Films", "Hidden Themes"])
 
     for date, data in hidden_themes.items():
-        table += "\n"
+        films = VCinemaUtils.get_film_list(data['viewings'])
 
-        row_data = []
-        row_data.append(str(date))
-        row_data.append(VCinemaUtils.get_film_list(data['viewings']))
         if 'hidden_themes' in data and data['hidden_themes'] != {}:
             hidden_theme_labels = []
 
@@ -77,10 +75,11 @@ def build_page(hidden_themes):
                 else:
                     hidden_theme_labels.append("<i>{} ({}%)</i>".format(hidden_theme, round(data['hidden_themes'][hidden_theme] * 100)))
 
-            row_data.append("<br>".join(hidden_theme_labels))
+            hidden_themes = "<br>".join(hidden_theme_labels)
         else:
-            row_data.append("N/A")
+            hidden_themes = "N/A"
 
-        table += " | ".join(row_data)
+        row_data = [date, films, hidden_themes]
+        table.add_row(row_data)
 
-    return table
+    return str(table)

wiki_pages/KeywordScores.py

@@ -5,6 +5,7 @@ from concurrent.futures import ThreadPoolExecutor
 
 from bookstack import Bookstack
 from imdb_utils import IMDbUtils
+from markdown_utils import MarkdownUtils
 from vcinema_utils import VCinemaUtils
 
 # Page ID of https://wiki.jacknet.io/books/vcinema/page/keyword-scores
@@ -66,16 +67,15 @@ def build_page(keyword_data, minimum_score=1.0):
     keyword_data = {k: v for k, v in keyword_data.items() if 'score' in v and v['score'] >= minimum_score}
     keyword_data = OrderedDict(sorted(keyword_data.items(), key=lambda t: t[1]['score'], reverse=True))
 
-    table = "| Keyword | Number of VCinema Films | Total IMDb entries | Score |\n| - | - | - | - |"
+    table = MarkdownUtils.MarkdownTable(["Keyword", "Number of VCinema Films", "Total IMDb entries", "Score"])
 
     for keyword, data in keyword_data.items():
-        table += "\n"
+        number_of_vcinema_films = len(data['vcinema_films'])
+        number_of_imdb_films = data['total']
+        keyword_score = round(data['score'], 3)
 
-        row_data = []
+        row_data = [keyword, number_of_vcinema_films, number_of_imdb_films, keyword_score]
-        row_data.append(str(keyword))
+
-        row_data.append(str(len(data['vcinema_films'])))
+        table.add_row(row_data)
-        row_data.append(str(data['total']))
-        row_data.append(str(round(data['score'], 3)))
-        table += " | ".join(row_data)
 
     return table